fix: let vite create final paths #400
Conversation
🦋 Changeset detectedLatest commit: 4722969 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## main #400 +/- ##
==========================================
- Coverage 96.53% 96.44% -0.09%
==========================================
Files 31 31
Lines 1097 1070 -27
Branches 227 221 -6
==========================================
- Hits 1059 1032 -27
Misses 38 38
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Could you please add a test? |
|
Fixed my issue with sveltekit adapter-static build |
|
@pzerelles we'd love to get this PR in as it seems to address issues people are having, but I'm afraid we don't understand it well enough yet. If you could take a look at adding a description and some tests that would be great |
|
I planned to add tests but didn't have the time yet. It is not so easy because the bigger part of the change affects only the "srcset" parameter and there was no test for this parameter before, as far as I could see. Will try to come up with something when I have time. Or we can talk on Discord about the change. |
This reverts commit 6beca2f.
|
Okay so two small things:
|
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR fixes the paths of images in the Vite build result. Before the filename was added to viteConfig.base which leads to relative urls that don't work anymore in nested paths.
What is the new behavior (if this is a feature change)?
Instead of inserting the final path in imagetools, the existing placeholder logic from Vite is used and Vite will do the replacement.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this
PR?)
Other information: